Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.3] User Action Logs Email #44709

Merged
merged 4 commits into from
Jan 26, 2025
Merged

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #39328 .

Summary of Changes

  1. the htmlbody string is sanitized by the html editor when it is loaded which is why {messages} is moved outside of the table. This PR moves {messages} to wrap the table instead of the row to avoid this sanitization and make the email work
  2. {messages} is missing from the params field in the database which is why it doesnt appear in the list of tags to insert and thus without that tag nothing is in the email

Testing Instructions Part 1

Set Mail Templates to send mail as html
Enable receiving action log emails for your user and do something to trigger an email eg saving an article
image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Testing Instructions Part 2

Open the User Actions Log: Notification Mail template

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

NOTE: If a user has already saved a User Actions Log: Notification Mail template they will need to press the reset HTML Body button.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon
Copy link
Contributor

alikon commented Jan 24, 2025

I have tested this item ✅ successfully on 9f3f7d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44709.

1 similar comment
@QuyTon
Copy link

QuyTon commented Jan 24, 2025

I have tested this item ✅ successfully on 9f3f7d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44709.

@QuyTon
Copy link

QuyTon commented Jan 24, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44709.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 24, 2025
@Hackwar
Copy link
Member

Hackwar commented Jan 26, 2025

I'm unhappy with moving the MESSAGES outside of the table, since it means it is duplicating the complete table instead of just the row, but it seems right now this is the only solution we have. Merging this now. Thank you!

@Hackwar Hackwar enabled auto-merge (squash) January 26, 2025 17:27
@Hackwar Hackwar added this to the Joomla! 5.2.4 milestone Jan 26, 2025
@brianteeman
Copy link
Contributor Author

@Hackwar I was never able to get more than one message in an email

@Hackwar Hackwar merged commit 365fb99 into joomla:5.2-dev Jan 26, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 26, 2025
@brianteeman brianteeman deleted the actionlogsmail branch January 26, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants